New Resource: Add DDos Protection Plan for Virtual Network. #2654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Co-Authored-By: metacpp <1684739+metacpp@users.noreply.github.com>
|
@katbyte, @metacpp I was developing something else against a build of master and I think I found a small bug in this - Azure seems to default ddos protection to false even when not specified, so you always get a diff resource "azurerm_resource_group" "resource_group" {
name = "hbtest_vnet"
location = "uksouth"
}
resource "azurerm_virtual_network" "virtual_network" {
name = "hbtest_vnet"
address_space = ["10.0.0.0/16"]
location = "${azurerm_resource_group.resource_group.location}"
resource_group_name = "${azurerm_resource_group.resource_group.name}"
}terraform apply -auto-approve
azurerm_resource_group.resource_group: Creating...
location: "" => "uksouth"
name: "" => "hbtest_vnet"
tags.%: "" => "<computed>"
azurerm_resource_group.resource_group: Creation complete after 1s (ID: /subscriptions/020ef497-e33d-4705-859b-08663256a4bc/resourceGroups/hbtest_vnet)
azurerm_virtual_network.virtual_network: Creating...
address_space.#: "" => "1"
address_space.0: "" => "10.0.0.0/16"
location: "" => "uksouth"
name: "" => "hbtest_vnet"
resource_group_name: "" => "hbtest_vnet"
subnet.#: "" => "<computed>"
tags.%: "" => "<computed>"
azurerm_virtual_network.virtual_network: Still creating... (10s elapsed)
azurerm_virtual_network.virtual_network: Creation complete after 11s (ID: /subscriptions/020ef497-e33d-4705-859b-...ft.Network/virtualNetworks/hbtest_vnet)
Apply complete! Resources: 2 added, 0 changed, 0 destroyed.
terraform plan
Refreshing Terraform state in-memory prior to plan...
The refreshed state will be used to calculate this plan, but will not be
persisted to local or remote state storage.
azurerm_resource_group.resource_group: Refreshing state... (ID: /subscriptions/020ef497-e33d-4705-859b-08663256a4bc/resourceGroups/hbtest_vnet)
azurerm_virtual_network.virtual_network: Refreshing state... (ID: /subscriptions/020ef497-e33d-4705-859b-...ft.Network/virtualNetworks/hbtest_vnet)
------------------------------------------------------------------------
An execution plan has been generated and is shown below.
Resource actions are indicated with the following symbols:
~ update in-place
Terraform will perform the following actions:
~ azurerm_virtual_network.virtual_network
ddos_protection_plan.#: "1" => "0"
Plan: 0 to add, 1 to change, 0 to destroy.Json returned from the API {
"name": "hbtest_vnet",
"id": "/subscriptions/xxx/resourceGroups/hbtest_vnet/providers/Microsoft.Network/virtualNetworks/hbtest_vnet",
"etag": "W/\"0611dcfd-bfc6-43cd-a2af-434ab17f827e\"",
"type": "Microsoft.Network/virtualNetworks",
"location": "uksouth",
"tags": {},
"properties": {
"provisioningState": "Succeeded",
"resourceGuid": "98c5a26b-ab3d-49f9-8564-e15b424f3d37",
"addressSpace": {
"addressPrefixes": [
"10.0.0.0/16"
]
},
"dhcpOptions": {
"dnsServers": []
},
"virtualNetworkPeerings": [],
"enableDdosProtection": false,
"enableVmProtection": false
}
} |
|
@hbuckle thanks for reporting this issue, I can reproduce it and I've prepared a quick fix for it. |
rakelkar
reviewed
Jan 30, 2019
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces:
azurerm_ddos_protection_plan, which is only allowed per region.ddos_protection_plan, inazurerm_virtual_network.